NPM: skip blank "file:" references in path dependencies#6229
Merged
jakecoffman merged 3 commits intomainfrom Nov 29, 2022
Merged
NPM: skip blank "file:" references in path dependencies#6229jakecoffman merged 3 commits intomainfrom
jakecoffman merged 3 commits intomainfrom
Conversation
jakecoffman
force-pushed
the
jakecoffman/fix-npm-eacces-path-dependency
branch
from
46845c1 to
5016455
Compare
jakecoffman
force-pushed
the
jakecoffman/fix-npm-eacces-path-dependency
branch
from
a25c1d9 to
3ffdf52
Compare
mctofu
approved these changes
Nov 28, 2022
Member
|
Nice find! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In NPM when you add a path dependency it can result in a blank
"file:"entry in the package-lock. The code here was taking that and callingFile.joinresulting in/package.jsonwhich later creates an EACCES error when it tries to write the package.json to the root directory.It seems these blank
file:sections are just for the parent dependency, so we can safely skip over them.