Refactor some common logic across ecosystems#6164
Merged
deivid-rodriguez merged 4 commits intomainfrom Nov 21, 2022
Merged
Conversation
Version and Requirement can be inferred from the package manager, no need to add additional options to the already complicated class.
This is only called with pinned versions, and it's kind of implied in the name.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/refactor-common-logic-across-ecosystems
branch
from
e28b9e9 to
b30b8d7
Compare
jurre
approved these changes
Nov 21, 2022
Contributor
Author
|
Thanks @jurre! I'll deploy this now to make sure it's all good! |
deivid-rodriguez
deleted the
deivid-rodriguez/refactor-common-logic-across-ecosystems
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #6071 I noticed some common logic across ecosystem that I think makes sense to be moved to common.
There's a lot of more that can be done here, but I didn't want to deviate too much from my original goal, so I stopped here which I believe is already an improvement.