Helm supports both .yml and .yaml#6096
Merged
Merged
Conversation
bdragon
approved these changes
Nov 9, 2022
jeffwidman
force-pushed
the
helm-supports-yml-and-yaml
branch
from
17281f7 to
07bf22b
Compare
jeffwidman
changed the title
.yml and .yaml..yml and .yaml
While pairing with `@bdragon`, he noticed this check is only looking for `*.yaml` files. However, we suspect Helm also supports `.yml` files. I found mention of `values.yml` in their documentation: https://v2.helm.sh/docs/developing_charts/#chart-development-tips-and-tricks So we should support it as well. Co-authored-by: Bryan Dragon <bdragon@github.com>
jeffwidman
force-pushed
the
helm-supports-yml-and-yaml
branch
from
07bf22b to
c35dd5e
Compare
This was referenced Nov 9, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While pairing with
@bdragon, he noticed this check is only looking for*.yamlfiles. However, we suspect Helm also supports.ymlfiles.I found mention of
values.ymlin their documentation: https://v2.helm.sh/docs/developing_charts/#chart-development-tips-and-tricksSo we should support it as well.
Co-authored-by: Bryan Dragon bdragon@github.com