Skip to content

Add note about why 3.9.3 omitted #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffwidman merged 1 commit into from
Nov 23, 2022
Merged

Add note about why 3.9.3 omitted #6043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/lib/dependabot/python/python_versions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ module PythonVersions

# Due to an OpenSSL issue we can only install the following versions in
# the Dependabot container.
Copy link
Copy Markdown
Member Author

@jeffwidman jeffwidman Nov 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the commit that added this: e43c80f

So when this note was added, the vulnerable versions were in the 3.5.x series... 3.6 is now EOL from upstream Python, although we're unofficially made a number of choices to continue to support it until Ubuntu 18.04 goes EOL this coming April.

Before that, there was a note about poetry not supporting python versions, which got added way back here: 6f734df#diff-fcc7191de583ab48f2202111f3076e45200c2ff6b83bb4b3f88425a81ee604e4R3-R8

So I wonder if poetry now supports this?? In which case we could drop this hardcoded python version list altogether?? 🤔

Copy link
Copy Markdown
Member Author

@jeffwidman jeffwidman Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed #6044 to track this, as not something I have time to look into right now. For now IMO we should merge this to unblock ourselves/get correct, then later circle back and clean this up.

# NOTE: When adding one version, always doublecheck for additional releases: https://www.python.org/downloads/
#
# WARNING: 3.9.3 is purposefully omitted as it was recalled: https://www.python.org/downloads/release/python-393/
SUPPORTED_VERSIONS = %w(
3.11.0
3.10.8 3.10.7 3.10.6 3.10.5 3.10.4 3.10.3 3.10.2 3.10.1 3.10.0
Expand Down