Skip to content

Sanitize file names in Dependabot::DependencyFile initializer #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattt wants to merge 1 commit into from
Closed

Sanitize file names in Dependabot::DependencyFile initializer #5986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion common/lib/dependabot/dependency_file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class Operation
def initialize(name:, content:, directory: "/", type: "file",
support_file: false, symlink_target: nil,
content_encoding: ContentEncoding::UTF_8, deleted: false, operation: Operation::UPDATE)
@name = name
@name = sanitize_name(name)
@content = content
@directory = clean_directory(directory)
@symlink_target = symlink_target
Expand Down Expand Up @@ -114,5 +114,11 @@ def clean_directory(directory)
# Directory should always start with a `/`
directory.sub(%r{^/*}, "/")
end

def sanitize_name(name)
# Ensure name is a relative path without relative path traversal
path = Pathname.new(name).cleanpath
File.join(path.split.reject { |c| c.root? || c.to_s == "." || c.to_s == ".." })
end
end
end