prevent trying to get a commit that can't exist#5981
Merged
jakecoffman merged 2 commits intomainfrom Oct 27, 2022
Merged
Conversation
Nishnha
approved these changes
Oct 26, 2022
Member
Nishnha
left a comment
There was a problem hiding this comment.
Looks correct to me
Definitely an improvement over the error cascades we had earlier - reminds me of throw null in Java
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #5937 caused Dependabot to begin raising an exception inside of the rescue for repositories that had a branch that didn't exist inside of their dependabot.yml.
What is happening is:
mark_job_as_processedbase_commit_shawhich... doesn't exist! So it also raises.This fixes two issues: