Remove Current User From List of Default Reviewer#5968
Merged
jeffwidman merged 8 commits intodependabot:mainfrom Oct 26, 2022
Merged
Conversation
…ttps://github.com/Kimor-hello/dependabot-core into bitbucket-remove-current-user-from-default-reviewer
jeffwidman
reviewed
Oct 25, 2022
Member
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Looks fine to me other than I am unclear why add the .ruby-version file?
To be clear, I have no way to integration test the client, it's very much a "we're happy to sanity check the code, but otherwise up to the community to maintain". Thank you for the unit test, that certainly helps.
…ttps://github.com/Kimor-hello/dependabot-core into bitbucket-remove-current-user-from-default-reviewer
jeffwidman
approved these changes
Oct 26, 2022
Member
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Looks good, thanks for including the unit test!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a pull request on bitbucket automatically fetch all default reviewer and add it to the reviewer list. However if the user logged in to use the dependabot script on bitbucket is one of the default reviewer, the pull request creation will fail.
To avoid this, this fetch the current user uuid and remove it from the default reviewer list if necessary.