Merged
Conversation
Member
Author
|
Not sure why this is passing... locally this fails all over the place for me... 😕 ?? May need #5959 to land first, as locally I'm running |
jeffwidman
force-pushed
the
fix-rubocop-mutable-freeze-warnings
branch
from
46bc765 to
f326130
Compare
jeffwidman
force-pushed
the
fix-rubocop-mutable-freeze-warnings
branch
from
f326130 to
df3f16d
Compare
jeffwidman
force-pushed
the
fix-rubocop-mutable-freeze-warnings
branch
from
df3f16d to
b8844f6
Compare
jeffwidman
force-pushed
the
fix-rubocop-mutable-freeze-warnings
branch
from
b8844f6 to
6ba910e
Compare
github-actions
bot
added
L: elixir:hex
Member
Author
|
This throws a lot fewer warnings for me now, not sure if we've changed our code or upstream fixed some bugs... regardless, the changes from |
landongrindheim
approved these changes
Jul 17, 2023
jeffwidman
force-pushed
the
fix-rubocop-mutable-freeze-warnings
branch
2 times, most recently
from
c75a16c to
83ad288
Compare
jeffwidman
changed the title
Rubocop is warning about mutable constants that should be frozen. These warnings started showing up as part of the Ruby 3.1 upgrade, and were excluded from that PR in order to minimize noise. So this PR fixes those warnings. I resolved them using `rubocop -A` and then visually inspecting them to confirm they looked reasonable.
jeffwidman
force-pushed
the
fix-rubocop-mutable-freeze-warnings
branch
from
83ad288 to
2e45e5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rubocop is warning about mutable constants that should be frozen.
These warnings started showing up as part of the Ruby 3.1 upgrade, and were excluded from that PR in order to minimize noise.
So this PR fixes those warnings.