Fix crashes on Python libraries using multiple manifests#5965
Merged
deivid-rodriguez merged 1 commit intomainfrom Oct 25, 2022
Merged
Fix crashes on Python libraries using multiple manifests#5965deivid-rodriguez merged 1 commit intomainfrom
deivid-rodriguez merged 1 commit intomainfrom
Conversation
bdragon
approved these changes
Oct 24, 2022
jeffwidman
approved these changes
Oct 25, 2022
If a library keeps a requirement duplicated in pyproject.toml/poetry.lock and a requirements.txt file, Dependabot updates will crash because we will try to widen requirements in the requirements file, which is not supported. Honestly, I don't know what users of this kind of setup expect so I opted for fixing the crash without changing the current behavior, namely, no updates.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/more-python-crashing
branch
from
982631d to
132c4c2
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a library keeps a requirement duplicated in
pyproject.toml/poetry.lock and a requirements.txt file, Dependabot updates will crash because we will try to widen requirements in the requirements file, which is not supported.
Honestly, I don't know what users of this kind of setup expect so I opted for fixing the crash without changing the current behavior, namely, no updates.