No public url call when public registry is disabled#5948
Merged
honeyankit merged 4 commits intomainfrom Oct 21, 2022
Merged
Conversation
jakecoffman
approved these changes
Oct 21, 2022
Member
jakecoffman
left a comment
There was a problem hiding this comment.
Makes sense, if the URL is empty we shouldn't automatically fall back to the public registry.
3872696 to
76cf547
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When pubic registry is disabled in the Nuget, it still tries to make a call to public registry url (
https://api.nuget.org/v3-flatcontainer/nuget.versioning/6.2.1/nuget.versioning.nuspec) to get the nuspec file if no nuspec file url is provided.Solution
Earlier, in the
dependency_nuspec_urlfunction of the metadata finder, a default public nuspec url was added if the source was missing or if the source was present but had no nuspec file. I have removed the injection of the default public nuspec url when there is either no source or no nuspec url specified in the source.Even without my change from this PR, when nuspec url was nil in source, the metadata finder was calling the default nuspec url and returning 404.
Note
Nuspec file: A .nuspec file is an XML manifest that contains package metadata. This manifest is used both to build the package and to provide information to consumers. The manifest is always included in a package. [ref]