Fix crash when updating git dependencies#5934
Merged
deivid-rodriguez merged 1 commit intomainfrom Oct 21, 2022
Merged
Conversation
a8843b3 to
3a8bfc1
Compare
pavera
approved these changes
Oct 20, 2022
If there's an evaled gemfile that also includes git dependencies, it
would result in a crash like the following:
```
Failure/Error:
dependency.requirements.
find { |f| f[:file] == file.name }.
fetch(:source).fetch(:ref)
NoMethodError:
undefined method `fetch' for nil:NilClass
fetch(:source).fetch(:ref)
```
We need to check the Gemfile name being updated, not generic names when
figuring out if we should update any git pins.
3a8bfc1 to
ed661cb
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's an evaled gemfile that also includes git dependencies, it would result in a crash like the following:
We need to check the Gemfile name being updated, not generic names when figuring out if we should update any git pins.