Maven: fix forgetting repositories seen in earlier POMs#5931
Merged
jakecoffman merged 2 commits intomainfrom Oct 20, 2022
Merged
Maven: fix forgetting repositories seen in earlier POMs#5931jakecoffman merged 2 commits intomainfrom
jakecoffman merged 2 commits intomainfrom
Conversation
pavera
approved these changes
Oct 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In project where POMs have grandparents (the POM's parent has a parent) we're seeing Dependabot forget about repositories it has seen in previous POMs. So it will start off well querying for a parent in a custom repository, but then forget about that and try to get the grandparent from Maven Central where it doesn't exist.
This PR adds tracking for URLs seen in POM files so that Dependabot can find the grandparent.
I was careful to keep the central repo URL out of the list of known URLs because if we have
[custom1, central]in the first POM and[custom2, central]in the second, that would add up to[custom1, central, custom2]which is not the ideal order.I tested this locally and it fixes #4168 and #5543. It also makes Dependabot "just work" in more cases now!