Fix updating to tags with a branch with same name#5918
Merged
deivid-rodriguez merged 1 commit intomainfrom Oct 20, 2022
Merged
Conversation
1 task
jurre
approved these changes
Oct 18, 2022
deivid-rodriguez
force-pushed
the
deivid-rodriguez/github_actions-handle-dup-branch-and-tag
branch
2 times, most recently
from
2094522 to
bc68355
Compare
When detecting whether a workflow file is pinned, we were assuming it's not pinned if there's a branch that matches the ref specified in the workflow file. However, if there's also a tag with the same name, that should probably take priority, since that's what users will expect in this case.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/github_actions-handle-dup-branch-and-tag
branch
from
bc68355 to
e1a8c49
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/github_actions-handle-dup-branch-and-tag
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detecting whether a workflow file is pinned, we were assuming it's not pinned if there's a branch that matches the ref specified in the workflow file.
However, if there's also a tag with the same name, that should probably take priority, since that's what users will expect in this case.
Fixes #5916.