Fall back to PR title if original PR head commit is missing#5913
Merged
Fall back to PR title if original PR head commit is missing#5913
Conversation
bdragon
force-pushed
the
bdragon/old-commit-msg
branch
from
919af7c to
26569b4
Compare
jurre
approved these changes
Oct 18, 2022
mattt
reviewed
Oct 18, 2022
bdragon
commented
Oct 18, 2022
Co-authored-by: Mattt <mattt@github.com>
mattt
approved these changes
Oct 19, 2022
Contributor
|
@bdragon Apologies, I may have early merged this PR due to misreading the deployment status. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pull request is updated, the PR updater assumes that it can re-use the commit message from an old pull request commit. If the appropriate commit has been lost, however, we've seen strange behavior wherein the message from an unrelated commit is used instead.
In this scenario (i.e., when the old commit is missing), ideally Dependabot should regenerate the commit message. Unfortunately we currently don't have the metadata necessary to do so at the point where the updater is invoked in our internal service. As an interim solution, this change uses the PR title as a fallback commit message to prevent the confusing behavior described above.