fix version_finder not preferring private registry#5907
Merged
jakecoffman merged 2 commits intomainfrom Oct 17, 2022
Merged
Conversation
honeyankit
approved these changes
Oct 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5884 I thought that passing in credential metadata to the RepositoryFinder was redundant since the
repositoriesmethod adds them, but that means it can't fetch parent poms when needed from private registries.I also fixed the ordering to be consistent with the RepositoryFinder.
This broke some specs, so I fixed those since it added some HEAD calls. Also noticed that the
rejectdidn't seem to work as URLs without auth_headers were still getting through, so I've fixed that as well.