Skip to content

[npm] Randomize advisory id to avoid cache collisions across tests #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mctofu merged 1 commit into from
Oct 12, 2022
Merged

[npm] Randomize advisory id to avoid cache collisions across tests #5875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions npm_and_yarn/helpers/lib/npm/vulnerability-auditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,19 +139,14 @@ async function findVulnerableDependencies(directory, advisories) {
}

function convertAdvisoriesToRegistryBulkFormat(advisories) {
// npm audit differentiates advisories by `id`. In order to prevent
// advisories from being clobbered, we maintain a counter so that each
// advisory gets a unique `id`.
let nextAdvisoryId = 1

return advisories.reduce((formattedAdvisories, advisory) => {
if (!formattedAdvisories[advisory.dependency_name]) {
formattedAdvisories[advisory.dependency_name] = []
}
let formattedVersions =
advisory.affected_versions.reduce((memo, version) => {
memo.push({
id: nextAdvisoryId++,
id: Math.floor(Math.random() * Number.MAX_SAFE_INTEGER),
vulnerable_versions: version
})
return memo
Expand Down