Fix Dependabot removes double backslashes in maven plugin configurations#5835
Merged
jeffwidman merged 2 commits intodependabot:mainfrom Oct 7, 2022
Conversation
jeffwidman
previously approved these changes
Oct 6, 2022
Member
jeffwidman
left a comment
There was a problem hiding this comment.
Thanks for including a test with this PR.
I've got a queue of PR's I'm trying to deploy/merge the next day or two, but will try to get this landed soon.
Member
|
Looks like there's a lint issue, can you fix? |
55413be to
88c6ef3
Compare
Contributor
Author
|
@jeffwidman |
jeffwidman
approved these changes
Oct 6, 2022
Member
jeffwidman
left a comment
There was a problem hiding this comment.
Awesome! Thanks. I'll try to get this deployed in the next few days and then assuming it looks good will merge it back to main
88c6ef3 to
0dc459f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dependabot removes backslashes in maven pom.
This PR will fix it.
Example PR: mallowlabs/dependabot-maven-double-backslashes-test#1
Reason
String#gsubescapes double backslashes.Using block prevents this problem.
Background
I use spotless-maven-plugin.
The
importOrderconfiguration contains\\#.https://github.com/diffplug/spotless/blob/7667a849d377b546d45350b77b65e0793e3d17dc/plugin-maven/README.md?plain=1#L184