Skip to content

Ensure always_clone is enabled for yarn_berry during file_fetching#5817

Merged
jurre merged 1 commit intomainfrom
jurre/yarn-berry-clone-during-fetching
Sep 30, 2022
Merged

Ensure always_clone is enabled for yarn_berry during file_fetching#5817
jurre merged 1 commit intomainfrom
jurre/yarn-berry-clone-during-fetching

Conversation

@jurre
Copy link
Copy Markdown
Member

@jurre jurre commented Sep 30, 2022

Previously we set the always_clone flag in the updater, but in prod we run file fetching as a separate step, and as a result the flag was not set at that point.

This change sets all the experiments on Dependabot::Experiment whenever we initialize a job. That way we can ensure that all the experiments are globally available during all steps.

@jurre jurre requested a review from a team as a code owner September 30, 2022 07:53
Previously we set the `always_clone` flag in the updater, but in prod we
run file fetching as a separate step, and as a result the flag was not
set at that point.

This change sets all the experiments on Dependabot::Experiment whenever
we initialize a job. That way we can ensure that all the experiments are
globally available during all steps.
@jurre jurre force-pushed the jurre/yarn-berry-clone-during-fetching branch from 0fc0677 to 6d00efe Compare September 30, 2022 09:07
Copy link
Copy Markdown
Contributor

@brrygrdn brrygrdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jurre jurre merged commit b0516da into main Sep 30, 2022
@jurre jurre deleted the jurre/yarn-berry-clone-during-fetching branch September 30, 2022 10:49
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants