[npm] Reject audits which don't have a fix we can apply#5815
Merged
Conversation
mctofu
changed the title
jeffwidman
approved these changes
Sep 30, 2022
mctofu
force-pushed
the
mctofu/audit-fix-incomplete
branch
from
cd5bfbf to
b3b3bd1
Compare
One reason for this is when the package-lock.json is not in sync with the package.json.
mctofu
force-pushed
the
mctofu/audit-fix-incomplete
branch
from
b3b3bd1 to
848c1e4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen this occurring when the
package-lock.jsonis not in sync with thepackage.json. In these cases the result containsfix_available: truebut thefix_updatesproperty is empty or contains dependencies with missing target versions.