[npm] Only return a chain if a node matches a vulnerable version#5785
Merged
[npm] Only return a chain if a node matches a vulnerable version#5785
Conversation
honeyankit
approved these changes
Sep 23, 2022
bdragon
approved these changes
Sep 23, 2022
Contributor
bdragon
left a comment
bdragon
left a comment
There was a problem hiding this comment.
Nice fix. Returning an empty array if the node's not vulnerable looks right to me 👍
Without this check we can surface already fixed versions of the dependency as needing to be updated which confuses Dependabot.
…need to look further
mctofu
force-pushed
the
mctofu/vuln-audit-safe-versions
branch
from
4655875 to
1354268
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this check we can surface already fixed versions of the dependency as needing to be updated which confuses Dependabot.