Skip to content

Set custom CA file path for yarn berry #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurre merged 8 commits into from
Sep 29, 2022
Merged

Set custom CA file path for yarn berry #5783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e30a7d7
Set custom CA file path for yarn berry
jurre Sep 22, 2022
df0bb64
Also set NODE_EXTRA_CA_CERTS
pavera Sep 23, 2022
060402b
Yarn renamed this config option in >4
pavera Sep 23, 2022
a8ff378
Add the http proxy settings so we don't pollute the global env
pavera Sep 23, 2022
a703649
protect against missing keys.
pavera Sep 23, 2022
49606d6
The whole command needs a guard
pavera Sep 23, 2022
936a32f
Set yarn CA file path config based on yarn version
jurre Sep 26, 2022
d99bcfb
Merge branch 'main' into jurre/yarn-berry-ca-path
jurre Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile.updater
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ bundle install
# executes the package manager outputs to every job log
COPY --chown=dependabot:dependabot updater/config/.yarnrc updater/config/.npmrc $DEPENDABOT_HOME/

# For Yarn Berry we can set this via an environment variable
ENV NODE_EXTRA_CA_CERTS=/etc/ssl/certs/ca-certificates.crt

# END: HACKY WORKAROUND FOR NPM GIT INSTALLS SPAWNING CHILD PROCESS

# Add project
Expand Down
15 changes: 15 additions & 0 deletions npm_and_yarn/lib/dependabot/npm_and_yarn/helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,21 @@ def self.npm_version_numeric(lockfile_content)
def self.run_yarn_commands(*commands)
# We never want to execute postinstall scripts
SharedHelpers.run_shell_command("yarn config set enableScripts false")
if (http_proxy = ENV.fetch("HTTP_PROXY", false))
SharedHelpers.run_shell_command("yarn config set httpProxy #{http_proxy}")
end
if (https_proxy = ENV.fetch("HTTPS_PROXY", false))
SharedHelpers.run_shell_command("yarn config set httpsProxy #{https_proxy}")
end
if (ca_file_path = ENV.fetch("NODE_EXTRA_CA_CERTS", false))
output = SharedHelpers.run_shell_command("yarn --version")
major_version = Version.new(output).major
if major_version >= 4
SharedHelpers.run_shell_command("yarn config set httpsCaFilePath #{ca_file_path}")
else
SharedHelpers.run_shell_command("yarn config set caFilePath #{ca_file_path}")
end
end
commands.each { |cmd| SharedHelpers.run_shell_command(cmd) }
end
end
Expand Down