Improve PR message for removed dependencies#5770
Merged
Conversation
mctofu
force-pushed
the
mctofu/removed_pr_message
branch
from
ca6886b to
18a1125
Compare
mctofu
force-pushed
the
mctofu/removed_pr_message
branch
from
18a1125 to
21959c2
Compare
jeffwidman
approved these changes
Sep 21, 2022
Nishnha
approved these changes
Sep 21, 2022
Member
Nishnha
left a comment
Nishnha
left a comment
There was a problem hiding this comment.
Nice improvement!
I found that I had to open new Dependabot security update PRs to see the updated messaging for transitive dependencies. The @dependabot recreate command didn't update it for some reason.
You might find that's also the case here.
mctofu
force-pushed
the
mctofu/removed_pr_message
branch
from
21959c2 to
1151c79
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on the message improvements in #5595 to also support cases where a dependency is removed.
Old
Bumps xmldom and read-excel-file. These dependencies needed to be updated together.
Removes
xmldomUpdates
read-excel-filefrom 4.1.0 to 5.4.7New
Removes xmldom. It's no longer used after updating ancestor dependency read-excel-file. These dependencies need to be updated together.
Removes
xmldomUpdates
read-excel-filefrom 4.1.0 to 5.4.7