Allow updating Java images with "update releases"#5734
Merged
jeffwidman merged 1 commit intomainfrom Sep 17, 2022
Merged
Conversation
deivid-rodriguez
force-pushed
the
deivid-rodriguez/docker-issues
branch
from
44cb638 to
9564b4f
Compare
jeffwidman
approved these changes
Sep 15, 2022
Member
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Nicely done! Thanks for being thoughtful with the commit attribution.
As per https://www.oracle.com/java/technologies/javase/versioning-naming.html, an underscore is used for "update release" segments. Co-authored-by: Rodrigo Petter <rodrigo-daniel@defensoria.rs.gov.br>
jeffwidman
force-pushed
the
deivid-rodriguez/docker-issues
branch
from
9564b4f to
559237a
Compare
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per
https://www.oracle.com/java/technologies/javase/versioning-naming.html, an underscore is used for "update release" segments.
This PR fixes #5728 and supersedes #4801.
I added attribution to @RodrigoPetter since I used his tests!
Diffferences from his PR are the implementation, which is simpler here, and the scope which limits only to segments followed by numbers, but does not deal with other cases since I have not seen those in real life.
Thanks so much Rodrigo!!