Skip to content

Fix URIs logged by dry-run#5732

Merged
deivid-rodriguez merged 1 commit intomainfrom
deivid-rodriguez/dry-run-logging
Sep 15, 2022
Merged

Fix URIs logged by dry-run#5732
deivid-rodriguez merged 1 commit intomainfrom
deivid-rodriguez/dry-run-logging

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

On the one hand, it was missing ":" after the colon. On the other hand, including the port makes the url not browsable, which I think it's the point of logging this.

Please trust me and don't even try to visit https//pypi.org, which is how I got here 🤣.

On the one hand, it was missing ":" after the colon. On the other hand,
including the port makes the url not browsable, which I think it's the
point of logging this.
@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner September 15, 2022 19:20
Copy link
Copy Markdown
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof! Good catch!

@deivid-rodriguez deivid-rodriguez merged commit f68191f into main Sep 15, 2022
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/dry-run-logging branch September 15, 2022 19:37
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants