Fix PHP-CS-Fixer deprecation warnings#5713
Merged
jeffwidman merged 1 commit intodependabot:mainfrom Sep 13, 2022
Merged
Conversation
Fix the following warnings: ``` 15.95 > php-cs-fixer fix --diff --verbose '--dry-run' 16.10 You are running PHP CS Fixer v2, which is not maintained anymore. Please update to v3. 16.10 You may find an UPGRADE guide at https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.3.0/UPGRADE-v3.md . 16.10 If you need help while solving warnings, ask at https://gitter.im/PHP-CS-Fixer, we will help you! 16.10 16.10 PHP CS Fixer 2.19.3 Testament by Fabien Potencier and Dariusz Ruminski 16.10 Runtime: PHP 7.4.30 16.10 Loaded config default from "/opt/composer/v1/.php_cs". 16.14 ...... 16.26 Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error 16.26 16.26 Checked all files in 0.134 seconds, 14.000 MB memory used 16.26 16.26 Detected deprecations in use: 16.26 - Option "ensure_fully_multiline" for rule "method_argument_space" is deprecated and will be removed in version 3.0. Use option "on_multiline" instead. 16.26 - Option "use_yoda_style" for rule "is_null" is deprecated and will be removed in version 3.0. Use "yoda_style" fixer instead. 16.26 - PhpCsFixer\Config::create is deprecated since 2.17 and will be removed in 3.0, use the constructor instead. 16.26 - Rule "no_multiline_whitespace_before_semicolons" is deprecated. Use "multiline_whitespace_before_semicolons" instead. ``` Originally I tried bumping `php-cs-fixer` to `v3` as suggested. But in dependabot#5694 I realized that was impossible given that `composer/composer` `v1` depended `composer/semver` `^v1` but `php-cs-fixer` `v3` requires `composer/semver` `v3`... So for now just fix some old deprecation warnings and move on. At least I got what I really wanted from this, which was to learn how Composer works.
jeffwidman
commented
Sep 13, 2022
| 'concat_space' => ['spacing' => 'one'], | ||
| 'declare_strict_types' => true, | ||
| 'increment_style' => ['style' => 'post'], | ||
| 'is_null' => ['use_yoda_style' => false], |
Member
Author
There was a problem hiding this comment.
This can be removed w/o any accompanying change since this file already has the new rule:
'yoda_style' => false,
bdragon
approved these changes
Sep 13, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following warnings:
Originally I tried bumping
php-cs-fixertov3as suggested. But in #5694 I realized that was impossible given thatcomposer/composerv1dependedcomposer/semver^v1butphp-cs-fixerv3requirescomposer/semverv3...So for now just fix some old deprecation warnings and move on.
At least I got what I really wanted from this, which was to learn how Composer works.