Test #conficting_dependencies with a locking parent dependabot fixture#5672
Merged
Test #conficting_dependencies with a locking parent dependabot fixture#5672
Conversation
mctofu
approved these changes
Sep 9, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new test for
UpdateChecker#conflicting_dependencieswhich uses a locking parent fixture so that the vulnerable transtitive dependency can't be upgraded.I created and published npm-parent-dependency-5 which has only 1 version
v1.0.0and requires exactlynpm-intermediate-dependency@0.0.1. In turn, this version ofnpm-intermediate-dependencyrequires exactlynpm-transitive-dependency@v1.0.0, locking it from upgrading to the non vulnerablev1.0.1.This test is subltly different from the "with a conflicting dependency and an unsatisfiable vulnerablity" test that already exists because it uses a valid vulnerable version range for
npm-transitive-dependencyof< 1.0.0which could be satisfied by upgrading tov1.0.1. Meanwhile, the existing test uses a version range that cannot be satisfied,< 1.0.2, because no such version ofnpm-transitive-dependencyexists.