Include removed dependency flag when creating a pull request#5671
Merged
Include removed dependency flag when creating a pull request#5671
Conversation
Eliminates the need to update all the existing smoke test expectations.
landongrindheim
approved these changes
Sep 9, 2022
Nishnha
reviewed
Sep 9, 2022
| end | ||
| end | ||
|
|
||
| context "with a removed dependency" do |
Member
There was a problem hiding this comment.
What happens if somehow we pass in removed: false instead of nil?
Contributor
Author
There was a problem hiding this comment.
It defaults to false so should be the same:
dependabot-core/common/lib/dependabot/dependency.rb
Lines 42 to 44 in a716ea6
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to support removed transitive dependencies.