Merged
Conversation
deivid-rodriguez
force-pushed
the
deivid-rodriguez/cleanup-updater-specs-output
branch
2 times, most recently
from
723e6a4 to
1e4063a
Compare
landongrindheim
approved these changes
Sep 8, 2022
Contributor
landongrindheim
left a comment
landongrindheim
left a comment
There was a problem hiding this comment.
TIL about #to_stdout_from_any_process
Up to now, running updater specs prints a lot of server logs with a lot of "E" letters that can be confused with spec failures, and it's hard to process. This commit adds some bare assertions on the output instead of printing it, so that it's clean.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/cleanup-updater-specs-output
branch
from
1e4063a to
f0c39c3
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/cleanup-updater-specs-output
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to now, running updater specs prints a lot of server logs with a lot of "E" letters that can be confused with spec failures, and it's hard to process.
This commit adds some bare assertions on the output instead of printing it, so that it's clean.
As a side effect, it also avoids using
expect { foo }.not_to raise_error. This is not considered a great testing practice because an empty implementation offoopasses it, so it's not testing much 😅.Sample output here (not everything because it's so verbose that exceeds maximum PR size 😆)
Before
After