Skip to content

fix smoke tests from forks by using public sources#5665

Merged
jakecoffman merged 1 commit intomainfrom
jakecoffman/fix-smoke-tests-for-forks
Sep 8, 2022
Merged

fix smoke tests from forks by using public sources#5665
jakecoffman merged 1 commit intomainfrom
jakecoffman/fix-smoke-tests-for-forks

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

Our smoke tests were broken for forks since PATs aren't available there. So I've moved the tests, caches, and CLI binary to public places so we can use GITHUB_TOKEN which is available as a read-only source.

@jakecoffman jakecoffman requested a review from a team as a code owner September 8, 2022 19:15
Copy link
Copy Markdown
Contributor

@honeyankit honeyankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jakecoffman jakecoffman force-pushed the jakecoffman/fix-smoke-tests-for-forks branch from ce3deee to 4a0b342 Compare September 8, 2022 19:34
@jakecoffman jakecoffman merged commit a3adc4e into main Sep 8, 2022
@jakecoffman jakecoffman deleted the jakecoffman/fix-smoke-tests-for-forks branch September 8, 2022 19:35
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants