Conversation
jurre
force-pushed
the
jurre/yarn-berry
branch
5 times, most recently
from
fe7da7a to
2e091f1
Compare
Closed
jurre
force-pushed
the
jurre/yarn-berry
branch
4 times, most recently
from
68de0b5 to
5efc6c5
Compare
jurre
changed the title
jurre
force-pushed
the
jurre/yarn-berry
branch
from
42ad037 to
db3a4c4
Compare
brrygrdn
reviewed
Sep 22, 2022
npm_and_yarn/lib/dependabot/npm_and_yarn/file_parser/lockfile_parser.rb
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks @brrygrdn / @landongrindheim, I've addressed those issues I think 🙇 |
npm_and_yarn/lib/dependabot/npm_and_yarn/file_parser/lockfile_parser.rb
Outdated
Show resolved
Hide resolved
landongrindheim
approved these changes
Sep 22, 2022
Contributor
landongrindheim
left a comment
landongrindheim
left a comment
There was a problem hiding this comment.
I'd love to see another 👍 from someone with better JS chops. Given the assurance that this is behind a feature flag, I'm happy to sign off 🚀
brrygrdn
reviewed
Sep 22, 2022
brrygrdn
reviewed
Sep 22, 2022
The v1 parser can handle the files just fine
Adds basic support for parsing + updating yarn berry projects using workspaces.
The package _name_ only contains `@npm:` if it's actually aliased, and looks like `my-fetch-factory@npm:fetch-factory`, the _requirement_ will have an additional `@npm:<version>` in yarn berry, but this is not present in the package name
In order to merge these changes into main without disrupting existing behavior, gate the changes behind a feature flag, so we can gradually roll them out and iron out issues without building up a huge set of changes.
This config option ensures that we don't run postinstall scripts that ship with npm packages. This is something we already do for all ecosystems including npm and yarn classic.
Co-authored-by: Landon Grindheim <landon.grindheim@gmail.com>
We'd rather not error if we can't determine the yarn version, returning `nil` is preferable.
Co-authored-by: Barry Gordon <896971+brrygrdn@users.noreply.github.com>
Co-authored-by: Landon Grindheim <landon.grindheim@gmail.com>
jurre
force-pushed
the
jurre/yarn-berry
branch
from
33c04de to
193d22d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for yarn-berry behind a feature flag, meaning that it won't run on repo's by default, but we can start using it to test targeted repo's.
There are a few notable known limitations: