Skip to content

Speed up dealing with non-reachable git repos #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deivid-rodriguez merged 1 commit into from
Sep 8, 2022
Merged

Speed up dealing with non-reachable git repos #5658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions common/lib/dependabot/git_commit_checker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,17 +365,19 @@ def listing_tag_for_version(version)
def listing_tags
return [] unless listing_source_url

tags = listing_repo_git_metadata_fetcher.tags
@listing_tags ||= begin
tags = listing_repo_git_metadata_fetcher.tags

if dependency_source_details&.fetch(:ref, nil)&.start_with?("tags/")
tags = tags.map do |tag|
tag.dup.tap { |t| t.name = "tags/#{tag.name}" }
if dependency_source_details&.fetch(:ref, nil)&.start_with?("tags/")
tags = tags.map do |tag|
tag.dup.tap { |t| t.name = "tags/#{tag.name}" }
end
end
end

tags
rescue GitDependenciesNotReachable
[]
tags
rescue GitDependenciesNotReachable
[]
end
end

def listing_upload_pack
Expand Down