move devcontainer to allow debugging updater with the default devcontainer#5648
Merged
jakecoffman merged 1 commit intomainfrom Sep 7, 2022
Merged
move devcontainer to allow debugging updater with the default devcontainer#5648jakecoffman merged 1 commit intomainfrom
jakecoffman merged 1 commit intomainfrom
Conversation
jakecoffman
commented
Sep 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that updater is in core, there's no way to use Codespaces to run the updater tests since the devcontainer.json we specified drops us in docker-dev-shell where updater doesn't exist.
So I've moved devcontainer.json to a subdirectory which gives us the ability to choose between the devcontainer.json we specified and the default one Codespaces uses:
Bonus: I noticed there was no cacheFrom specified, so I've added one and it seems to be using it when building. This should save some time!