Skip to content

Remove links to reduce timeline noise#5643

Closed
landongrindheim wants to merge 4 commits intomainfrom
reduce-timeline-noise
Closed

Remove links to reduce timeline noise#5643
landongrindheim wants to merge 4 commits intomainfrom
reduce-timeline-noise

Conversation

@landongrindheim
Copy link
Copy Markdown
Contributor

@landongrindheim landongrindheim commented Sep 6, 2022

🖼️ Context

In an attempt to reduce noise in timelines, I'm removing links to PRs opened by Dependabot. I've opted to leave non-bot contributors for now.

I also inserted a zero-width space between @ and handle in the release notes so as to limit notification noise. If this is unwelcome, please let me know 🙂

Closes #5639

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

@landongrindheim Not sure if this is helpful, but this is the original report with links with the fix that was implemented at the time: #3276.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

It seems that we have regressed somewhere but I have no idea where or how. This PR seems like a workaround for now to stop the bleeding? I mean we always showed links, and GitHub didn't create cross references until now. With this solution, we would lose the links?

@landongrindheim
Copy link
Copy Markdown
Contributor Author

landongrindheim commented Sep 6, 2022

Thanks @deivid-rodriguez! I misread this report. Looking closer, it appears that we started spamming yesterday (Sept 5th):
image

That should help track this down.


The closes PR I see was the Rubocop Performance change, which was merged a few hours before these started appearing.

@jeffwidman
Copy link
Copy Markdown
Member

jeffwidman commented Sep 6, 2022

Could this be at all related to internal work on the monolith or api back end? I know some of the team was recently touching code around PR generation there... perhaps a side effect? Might want to circle up with them internally.

@bakkot
Copy link
Copy Markdown

bakkot commented Sep 6, 2022

Looking closer, it appears that we started spamming yesterday (Sept 5th):

If you're referring to tc39/ecma262#2819, it's not that something in Dependabot changed at that time; rather, that's when the babel release which mentioned said PR went out.

@landongrindheim
Copy link
Copy Markdown
Contributor Author

Closing this as it did not address the intended issue

@landongrindheim landongrindheim deleted the reduce-timeline-noise branch September 8, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github links in release notes cause timeline notification spam

5 participants