Skip to content

Speedup rebuilding native helper changes#5624

Merged
deivid-rodriguez merged 2 commits intomainfrom
deivid-rodriguez/speedup-developing-native-helpers
Sep 5, 2022
Merged

Speedup rebuilding native helper changes#5624
deivid-rodriguez merged 2 commits intomainfrom
deivid-rodriguez/speedup-developing-native-helpers

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

I was working on improving #5617, and while changing the pub native helper script, I noticed that rebuilding would rebuild native helpers for all ecosystems.

I think reordering things this way should make things a bit more efficient.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner September 5, 2022 09:00
@jurre
Copy link
Copy Markdown
Member

jurre commented Sep 5, 2022

Change is 👍 to me, but did you verify it's actually faster? 😄 I've been surprised by Docker caching behavior a few times

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Yeah, I did this while making changes to pub native helpers and after this when rebuilding you would no longer rebuild composer helpers, which are quite slow to rebuild, and others, making things faster!

Here, worst case scenario is changing composer helpers. No speedup there because it's the first in the list so changing any native helper file there triggers a rebuild of everything.

Best case scenario is changing terraform helpers. Since they come last in the list, changes in them will only cause rebuilding terraform native helpers but nothing else from other ecosystems.

Right now if I'm working on Pub native helpers and I rebuild the
image, I need to reinstall all native helpers for all other ecosystems.
This change avoids some unnecessary build scripts, depending on the
ecosystem.
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/speedup-developing-native-helpers branch from 1dae9b7 to 553e5e7 Compare September 5, 2022 09:25
@deivid-rodriguez deivid-rodriguez merged commit 09a7232 into main Sep 5, 2022
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/speedup-developing-native-helpers branch September 5, 2022 10:02
@mctofu mctofu mentioned this pull request Sep 6, 2022
@Nishnha
Copy link
Copy Markdown
Member

Nishnha commented Sep 7, 2022

This is really surprising behavior. Thanks for the speed up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants