Skip to content

only use GHCR for deploys#5614

Merged
jakecoffman merged 2 commits intomainfrom
jakecoffman/faster-deploys
Sep 2, 2022
Merged

only use GHCR for deploys#5614
jakecoffman merged 2 commits intomainfrom
jakecoffman/faster-deploys

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

We created two ways to deploy Dependabot Updater internally:

  1. Push the Updater to GHCR
  2. Export an image of the Updater and save it as an artifact for more processing later

Due to layer caching and the size of the image, saving it as an artifact takes a significant amount of time compared to just using GHCR. So we're going to remove it and just use GHCR.

@jakecoffman jakecoffman requested a review from a team as a code owner September 1, 2022 19:57
@jakecoffman jakecoffman force-pushed the jakecoffman/faster-deploys branch 2 times, most recently from 160a4ec to 726a0a6 Compare September 1, 2022 20:18
Copy link
Copy Markdown
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash before merging? I'm not opposed to multiple commits, just these mostly look like fixups so rather squash them down into the primary commit

@jakecoffman jakecoffman force-pushed the jakecoffman/faster-deploys branch from a0cb08a to 8d2e828 Compare September 2, 2022 12:10
@jakecoffman jakecoffman force-pushed the jakecoffman/faster-deploys branch from 8d2e828 to d77cc8b Compare September 2, 2022 12:14
@jakecoffman jakecoffman merged commit 3cf4655 into main Sep 2, 2022
@jakecoffman jakecoffman deleted the jakecoffman/faster-deploys branch September 2, 2022 12:55
@mctofu mctofu mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants