Run rspec with --profile flag by default in Python#5607
Merged
deivid-rodriguez merged 1 commit intomainfrom Sep 8, 2022
Merged
Run rspec with --profile flag by default in Python#5607deivid-rodriguez merged 1 commit intomainfrom
rspec with --profile flag by default in Python#5607deivid-rodriguez merged 1 commit intomainfrom
Conversation
jeffwidman
approved these changes
Aug 31, 2022
jurre
approved these changes
Sep 8, 2022
It occurred to me that maybe printing to 10 slowest examples would raise awareness on the areas that need more love with regards to test speed in the Python suite, which is notoriously slow.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/rspec-profile-by-default-in-python
branch
from
5c74e1a to
cd55bac
Compare
Contributor
Author
|
@jurre I just noticed that updater does this same thing, but enabling profiling through configuration instead ( |
deivid-rodriguez
deleted the
deivid-rodriguez/rspec-profile-by-default-in-python
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag prints the slowest 10 specs and their run times after each rspec run.
Because our Python test suite is so slow, It just occurred to me that maybe using it by default in Python would raise awareness on the areas that need more love with regards to test speed.