Properly upgrade github actions pinned to specific commits#5576
Merged
deivid-rodriguez merged 4 commits intomainfrom Sep 6, 2022
Merged
Properly upgrade github actions pinned to specific commits#5576deivid-rodriguez merged 4 commits intomainfrom
deivid-rodriguez merged 4 commits intomainfrom
Conversation
95fef7c to
5fee432
Compare
9e07bc7 to
3f5bb4f
Compare
Contributor
Author
|
Added some specs here, so this is now ready from my side! |
151dd9c to
1586708
Compare
For readability and for later reuse.
If the pinned commit sha is not the tip of any repo branch, we would "update" to the commit sha of the latest version, which might be actually a parent of the current sha. The problem is that so far we were not cloning the repository, so all we can access is sha's discoverable through http `/info/refs` endpoint, or through `git ls-remotes`. To properly update this kind of references, we need to clone the repository.
1586708 to
defa05c
Compare
landongrindheim
approved these changes
Sep 6, 2022
Contributor
Author
|
Thank you for your reviews, let's do this! |
Merged
1 task
This was referenced Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the pinned commit sha is not the tip of any repo branch, we would "update" to the commit sha of the latest version, which might be actually a parent of the current sha.
The problem is that so far we were not cloning the repository, so all we can access is sha's discoverable through http
/info/refsendpoint, or throughgit ls-remotes.To properly update this kind of references, we need to clone the repository.
This is not ready at all, it at least needs some tests, but I wanted to share it.
Fixes #5556.
Before (downgrades to the sha of v17)
After (upgrades to the latest commit in master)