Experimenting with speeding up development Dockerfile build#5528
Closed
deivid-rodriguez wants to merge 2 commits intomainfrom
Closed
Experimenting with speeding up development Dockerfile build#5528deivid-rodriguez wants to merge 2 commits intomainfrom
deivid-rodriguez wants to merge 2 commits intomainfrom
Conversation
This could technically speed up booting some scripts a bit, but it differs from the most standard Bundler setup and makes things hard to work with the new version switcher shipped with Bundler.
I think this gem location is only read, and it's the same for every ecosystem. Maybe it can be reused.
Contributor
Author
|
I think maybe this works? But CI is not a good way to test this kind of change, since it's us who exercise the development Dockerfile, not the CI. But at least we know the change I made in the main Dockerfile does not break CI. |
| RUN cd nuget && bundle config path ${CODE_DIR}/common/.bundle | ||
| RUN cd python && bundle config path ${CODE_DIR}/common/.bundle | ||
| RUN cd pub && bundle config path ${CODE_DIR}/common/.bundle | ||
| RUN cd terraform && bundle config path ${CODE_DIR}/common/.bundle |
Contributor
Author
There was a problem hiding this comment.
If we do this, I can condense this to a single layer, just wanted to put a proof of concept out quickly.
Contributor
Author
|
Closing as per #5520 (comment). |
deivid-rodriguez
deleted the
deivid-rodriguez/speed-up-dev-dockerfile-build
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.