Skip to content

URL decode Nuget API v2 "next" link when paging version results #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffwidman merged 2 commits into from
May 24, 2022
Merged

URL decode Nuget API v2 "next" link when paging version results #5174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62366e4
URL decode Nuget API v2 "next" link when paging version results
tomcain May 20, 2022
2cd1fb2
Fixing rubocop issue, replacing :: with .
tomcain May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nuget/lib/dependabot/nuget/update_checker/version_finder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def fetch_paginated_v2_nuget_listings(url_details, results = {})

if (link_href = fetch_v2_next_link_href(response.body))
url_details = url_details.dup
url_details[:versions_url] = link_href
url_details[:versions_url] = CGI.unescape(link_href)
fetch_paginated_v2_nuget_listings(url_details, results)
end

Expand Down