[Maven] Fix some malformed memoizations#5132
Merged
Conversation
brrygrdn
commented
May 11, 2022
Comment on lines
157
to
158
Contributor
Author
There was a problem hiding this comment.
This memoization pattern works, but I found it hard to read so this is an opinionated change just to improve the readability.
It does make it a little easier to maintain in the event that the fetch_dependency_metadata code was ever to return a falsy value rather than a blank string.
landongrindheim
approved these changes
May 12, 2022
brrygrdn
force-pushed
the
brrygrdn/maven-memoization-cleanup
branch
from
8f2dd73 to
3a53e44
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR collects up a pass on any methods that make
Excon.getcalls which attempt to memoize the outcome of requests.I found a couple of cases where the pattern used wouldn't correctly memoize falsy values and fall through to making the request a second time.
From walking through the code I don't think these will have any performance implications unfortunately, I don't believe these methods are called more than once in any of our runtimes, but it could catch us out in future.