Skip to content

Add --network-trace to dry-run #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brrygrdn merged 2 commits into from
May 13, 2022
Merged

Add --network-trace to dry-run #5131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
667b42d
Instrument Excon, add --network-trace to dry-run
brrygrdn May 11, 2022
31fa596
Make networking tracking a default
brrygrdn May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bin/dry-run.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,14 @@ def handle_dependabot_error(error:, dependency:)

StackProf.start(raw: true) if $options[:profile]


$network_trace_count = 0
ActiveSupport::Notifications.subscribe(/excon.request/) do |*args|
$network_trace_count += 1
payload = args.last
puts "🌍 #{payload[:scheme]}//#{payload[:host]}:#{payload[:port]}#{payload[:path]}"
end

$source = Dependabot::Source.new(
provider: $options[:provider],
repo: $repo_name,
Expand Down Expand Up @@ -774,6 +782,8 @@ def security_fix?(dependency)
StackProf.stop if $options[:profile]
StackProf.results("tmp/stackprof-#{Time.now.strftime('%Y-%m-%d-%H:%M')}.dump") if $options[:profile]

puts "🌍 Total requests made: '#{$network_trace_count}'"

# rubocop:enable Metrics/BlockLength

# rubocop:enable Style/GlobalVars
2 changes: 2 additions & 0 deletions common/lib/dependabot/shared_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# frozen_string_literal: true

require "active_support/notifications"
require "digest"
require "English"
require "excon"
Expand Down Expand Up @@ -150,6 +151,7 @@ def self.excon_defaults(options = nil)
options ||= {}
headers = options.delete(:headers)
{
instrumentor: ActiveSupport::Notifications,
connect_timeout: 5,
write_timeout: 5,
read_timeout: 20,
Expand Down
1 change: 1 addition & 0 deletions common/spec/dependabot/shared_helpers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ def existing_tmp_folders

it "includes the defaults" do
expect(subject).to eq(
instrumentor: ActiveSupport::Notifications,
connect_timeout: 5,
write_timeout: 5,
read_timeout: 20,
Expand Down