Skip to content

[Maven] Avoid retrying requests to repos excessively #5130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brrygrdn merged 2 commits into from
May 13, 2022
Merged

[Maven] Avoid retrying requests to repos excessively #5130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b642e9
Explicitly set Excon timeouts in SharedHelpers
brrygrdn May 4, 2022
020a9c2
When finding repository urls, only retry once
brrygrdn May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common/lib/dependabot/shared_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ def self.excon_defaults(options = nil)
connect_timeout: 5,
write_timeout: 5,
read_timeout: 20,
retry_limit: 4, # Excon defaults to four retries, but let's set it explicitly for clarity
omit_default_port: true,
middlewares: excon_middleware,
headers: excon_headers(headers)
Expand Down
1 change: 1 addition & 0 deletions common/spec/dependabot/shared_helpers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ def existing_tmp_folders
connect_timeout: 5,
write_timeout: 5,
read_timeout: 20,
retry_limit: 4,
omit_default_port: true,
middlewares: described_class.excon_middleware,
headers: described_class.excon_headers
Expand Down
5 changes: 5 additions & 0 deletions maven/lib/dependabot/maven/file_parser/repositories_finder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ def fetch_remote_parent_pom(group_id, artifact_id, version, repo_urls)
@maven_responses[url] ||= Excon.get(
url,
idempotent: true,
# We attempt to find dependencies in private repos before failing over to the CENTRAL_REPO_URL,
# but this can burn a lot of a job's time against slow servers due to our `read_timeout` being 20 seconds.
#
# In order to avoid the overall job timing out, we only make one retry attempt
retry_limit: 1,
**SharedHelpers.excon_defaults
)
next unless @maven_responses[url].status == 200
Expand Down