Skip to content

Validate before creating version objects in Dependabot::NpmAndYarn::UpdateChecker::VersionResolver #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 2 commits into from
May 10, 2022
Merged

Validate before creating version objects in Dependabot::NpmAndYarn::UpdateChecker::VersionResolver #5120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df8b75
Add early returns when version string is invalid
mattt May 10, 2022
0d50dbc
Formatting
mattt May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,10 @@ def types_update_available?

return false unless latest_allowable_version.backwards_compatible_with?(latest_types_package_version)

return false unless version_class.correct?(types_package.version)

current_types_package_version = version_class.new(types_package.version)

return false unless current_types_package_version < latest_types_package_version

true
Expand All @@ -261,9 +264,12 @@ def types_update_available?
def original_package_update_available?
return false if original_package.nil?

latest_version = latest_version_finder(original_package).latest_version_from_registry
return false unless version_class.correct?(original_package.version)

original_package_version = version_class.new(original_package.version)

latest_version = latest_version_finder(original_package).latest_version_from_registry

original_package_version < latest_version
end

Expand Down