Use a temporary Ruby requirement for updating lockfile#5019
Merged
jurre merged 1 commit intodependabot:mainfrom Apr 22, 2022
Merged
Use a temporary Ruby requirement for updating lockfile#5019jurre merged 1 commit intodependabot:mainfrom
jurre merged 1 commit intodependabot:mainfrom
Conversation
Contributor
Author
There was a problem hiding this comment.
I could've used >= 3.1 in the fixture gemspec, and that would've worked, but once Dependabot upgrades to Ruby 3.1, the test would stop covering this fix. So this is my attempt to make the test independent from the Ruby version being run.
To ensure that no Ruby resolution conflicts are generated.
deivid-rodriguez
force-pushed
the
ruby-version-fix
branch
from
a6d15e9 to
6337925
Compare
Contributor
Author
|
You're welcome! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure that no Ruby resolution conflicts are generated.
This PR fixes the issue mentioned in this comment.