Skip to content

Update Bundler from 2.3.10 to 2.3.12#5018

Merged
jurre merged 1 commit intodependabot:mainfrom
deivid-rodriguez:bundler-2-3-12
Apr 22, 2022
Merged

Update Bundler from 2.3.10 to 2.3.12#5018
jurre merged 1 commit intodependabot:mainfrom
deivid-rodriguez:bundler-2-3-12

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez commented Apr 20, 2022

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner April 20, 2022 16:32
Copy link
Copy Markdown
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

Oooops, something actually broke here. Let me have a look.

Includes some changes in monkeypatches.

* Don't use `Bundler::RubyVersion#to_gem_version_with_patchlevel` since
  it has been removed by
  ruby/rubygems@21c145c.

* Opt out of always passing the running Ruby version as a resolver
  requirement
  (ruby/rubygems@4156c70),
  since it's necessary for dependabot to work.
@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

@jurre This one should be ok now. It actually complicated the monkey patch a bit, but I now understand better why you need to do this, so I hope to support this use case better upstream in the future. Also, and related to this, I introduced a regression that could affect Dependabot in RubyGems 3.3.12, but Dependabot still uses 3.2.20 and I'm fixing it ASAP, so it should be ok.

@jurre
Copy link
Copy Markdown
Member

jurre commented Apr 22, 2022

@jurre This one should be ok now. It actually complicated the monkey patch a bit, but I now understand better why you need to do this, so I hope to support this use case better upstream in the future. Also, and related to this, I introduced a regression that could affect Dependabot in RubyGems 3.3.12, but Dependabot still uses 3.2.20 and I'm fixing it ASAP, so it should be ok.

Cheers! We should really have a bit of documentation on those monkey patches because I also forget why we have them until they break and I need to fix them again :(

@jurre jurre merged commit 93e1c50 into dependabot:main Apr 22, 2022
@deivid-rodriguez deivid-rodriguez deleted the bundler-2-3-12 branch April 22, 2022 11:31
@brrygrdn brrygrdn mentioned this pull request Apr 25, 2022
mctofu added a commit that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants