Conversation
Make these versions more flexible so that we continue to support python 3.6
|
This makes sense now that I learned the Python helpers are run with the target version of Python. Many of the spec are integration style tests already, they make calls to GitHub and compile external code! So maybe stick a new test in Also, I noticed this file dependabot-core/python/lib/dependabot/python/python_versions.rb Lines 12 to 19 in 48f4df6 Should we test back to 3.5.3? 🤔 |
|
Yeah, I also had read the version file, going back to 3.5 pulls these two packages back quite a ways. I figured I'd wait and see on that. 3.6 is already eol, but ubuntu 18.04 is still supported and that is the official python version there. Not sure if there are any supported distros that are keeping 3.5 alive still (rhel/centos maybe?) Good to know about the tests, I will endeavor to add one for this case. |
This PR restores python 3.6 support by allowing version ranges for pip and pip-tools. The latest versions of these dependencies no longer support python 3.6, so we need to allow earlier versions.
Looking into an issue creating PRs for a python repo found that if you specify a python version, IE 3.6.8 for your repo, then when we attempt to create the 3.6.8 pyenv and pip install -r python/helpers/requirements.txt it fails because some dependencies in this helper have removed python 3.6 support in their latest versions.
I'm not clear on whether dependabot will just immediately try to bump these versions again? If it will what is the correct way to pin these versions back?
I'd like to add tests as well, but need a pointer or 2 about where to add such "integration" type tests.