Remove workaround for broken ruby gems compare#4933
Merged
landongrindheim merged 1 commit intodependabot:mainfrom Mar 31, 2022
Merged
Conversation
This was added in dependabot@cdb346e as a temporary workaround until ruby/rubygems#2651 shipped. It looks like that shipped in Ruby Gems 3.1.0, and Dependabot is currently on Ruby Gems `3.2.20`: https://github.com/dependabot/dependabot-core/blob/9c090f6fe573aa3b6b05d20920c7c48f5f00403f/Dockerfile#L77 So this should be safe to remove. Note that I removed the code workaround from the original commit, but not the test cases... so they should catch any regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in cdb346e as a temporary workaround
until ruby/rubygems#2651 shipped.
It looks like that shipped in Ruby Gems
3.1.0, and Dependabot is currently onRuby Gems
3.2.20:dependabot-core/Dockerfile
Line 77 in 9c090f6
So this should be safe to remove.
Note that I removed the code workaround from the original commit, but
not the test cases... so they should catch any regressions.