Prevent unnecessary composer package downloads#4635
Merged
feelepxyz merged 1 commit intodependabot:mainfrom Jan 27, 2022
Merged
Conversation
This was referenced Jan 15, 2022
feelepxyz
reviewed
Jan 25, 2022
Contributor
feelepxyz
left a comment
feelepxyz
left a comment
There was a problem hiding this comment.
Amazing work on this! 🎉 I think this looks good, will give it a quick QA test locally to verify.
Thanks for updating the tests, not raising for these cases is a real nice improvement.
Member
|
This seems very promising, thanks @driskell 🎉 @feelepxyz do you need a hand w/ QAing? |
feelepxyz
approved these changes
Jan 27, 2022
Contributor
feelepxyz
left a comment
feelepxyz
left a comment
There was a problem hiding this comment.
Tested this out a few test repos and working nicely! Double win here, speeding up composer v2 updates and removing a class of update errors where downloads needed authentication 🎉
This is in line with other package managers so great to see this working in composer now.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents all installations of packages during composer updates. It significantly increases speed of updates.
This was discussed in #2999 and should help greatly with #2416.
Previous PR was #2998 and I closed it as I thought there was issues with this approach, as https://github.com/wikimedia/composer-merge-plugin stopped working. After rechecking with existing dependabot-core main branch I did see setScripts is false already and was able to reproduce the merge-plugin issue there. Having thought about it I think it's unreasonable to support that plugin in dependabot - even if the packages merged in weren't removed there would still be incompatibility in that packages merged in won't get dependabot updates. So I've produced this PR again as it was for discussion.
Credit should also go to @jurre here as it's a progression from #3009.