Merged
Conversation
Member
|
Nice one, I think this makes sense 👍 I'm not entirely sure that we have folks to staff all these teams, so that's something that we'll need to figure out. |
brrygrdn
approved these changes
Mar 22, 2022
Contributor
brrygrdn
left a comment
brrygrdn
left a comment
There was a problem hiding this comment.
👍🏻 I think this is a good idea, it makes sense to get the logistics in terms of branch protection, etc in place so we can start filling out these teams with more reviewers
jurre
reviewed
Apr 22, 2022
Co-authored-by: Jurre <jurre@github.com>
mattt
commented
Apr 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CODEOWNERS file to have ecosystem-specific teams suggested as reviewers on relevant PRs. For example, the team of Java reviewers would be suggested for a PR that touches either the
gradleormavensubdirectories.Before merging this PR, we need to create the corresponding teams, likely as sub-teams to @dependabot/reviewers. After merging this PR, we should update our branch protection rules to require approval by the codeowners.