Gitlab: add support for creating merge requests for forks#4324
Merged
jurre merged 3 commits intodependabot:mainfrom Oct 18, 2021
andrcuns:gitlab-add-fork-support
Merged
Gitlab: add support for creating merge requests for forks#4324jurre merged 3 commits intodependabot:mainfrom andrcuns:gitlab-add-fork-support
jurre merged 3 commits intodependabot:mainfrom
andrcuns:gitlab-add-fork-support
Conversation
Validate target_project_id passed correctly Fix request expectation
jurre
reviewed
Oct 18, 2021
jurre
reviewed
Oct 18, 2021
Member
|
Overall sounds like this approach makes sense for gitlab, I made some suggestions to avoid adding provider-specific keys to the (already large 😅) list of arguments we pass to these classes |
Contributor
Author
Makes sense, I missed the |
jurre
approved these changes
Oct 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating merge requests from a forked project in to the upstream project.
Because Gitlab doesn't prevent running the pipeline for merge request created within the project like it happens with workflows created by dependabot in github repositories, a malicious dependency would gain access to all environment variables, including keys, secrets etc.
For this purpose users might want to setup a fork of a project and use a less privileged user to run the dependabot-core and create merge requests from forks. This way the pipeline is not gaining access to secrets of the upstream project until user manually reviews the updates and triggers the pipeline as a more privileged user.